-
Notifications
You must be signed in to change notification settings - Fork 14k
Handle OOM when writing to Vec
#148024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Handle OOM when writing to Vec
#148024
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
Seems similar to #84612 Cc @kornelski |
|
IMHO this is a good idea. This is an It may be worth making this explicit in the documentation that it applies to Vec too. PR #84612 got postponed in hope that |
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
The use of these methods will most likely be in generic context anyway, where errors will be properly handled. |
I haven't found any discussion on this, but I think that handling those OOM is desirable.